-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
@Jochen-A-Fuerbacher Are you still interested in working on this? |
@jeremyn Yes, I am still interested in working on this. However, for the moment I think this could be merged. |
There are several more subdomains for Also, please fix the indentation. Each indentation should be one tab, no spaces. |
@jeremyn Thank you for your comment. I added more targets. |
Please make the following changes. For the removal items, these are based some informal rules: don't include domains if they aren't in DNS ( Remove these domains from the top comment:
Remove these
Move to comment
Add Also: |
I've updated the checklist through 414ac37, thanks. The remaining items are not finished because you didn't delete the requested comments. Also, we like to squash-and-merge pull requests, which means we combine and rewrite pull requests in your name. Is that all right with you for this and any other pull requests you submit to us? Additionally, for this pull request, I want to delete all of your individual commits when I do the merge. Is that all right? (Please don't do that yourself, it might make it harder to review your remaining changes.) |
Yes, you can squash-and-merge the pull request and delete the individual commits. |
Thanks, merged. |
No description provided.