Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Added rule for HsKA IWI faculty. #7406

Merged
merged 7 commits into from
Dec 22, 2016
Merged

Conversation

Jochen-A-Fuerbacher
Copy link
Contributor

No description provided.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 3, 2016

@Jochen-A-Fuerbacher Are you still interested in working on this?

@Jochen-A-Fuerbacher
Copy link
Contributor Author

@jeremyn Yes, I am still interested in working on this. However, for the moment I think this could be merged.

@jeremyn jeremyn self-assigned this Dec 3, 2016
@jeremyn
Copy link
Contributor

jeremyn commented Dec 4, 2016

There are several more subdomains for hs-karlsruhe.de that should be added either as working targets or noted in a comment at the top as non-working. Please look at our style guide and use either Sublist3r or the Google search strategy described there to find more subdomains. See here for an example of a top comment.

Also, please fix the indentation. Each indentation should be one tab, no spaces.

@Jochen-A-Fuerbacher
Copy link
Contributor Author

@jeremyn Thank you for your comment. I added more targets.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 20, 2016

Please make the following changes. For the removal items, these are based some informal rules: don't include domains if they aren't in DNS (Server not found); don't include domains if both HTTPS and HTTP have problems. I also don't like to include domains that are purely internal infrastructure like VPN, webmail, or security devices, but there's some room for debate there. I give reasons for most of the changes in parentheses but let me know if you have questions about any of these requested changes.

Remove these domains from the top comment:

Remove these targets:

Move to comment Invalid certificate:

Add target, remove from comment:

Also:

  • Change the top comment from this to have formatting and placement like this
  • Delete the <!-- General --> and <!-- Faculty of ... --> comments and move the Faculty domains into the General list

@jeremyn
Copy link
Contributor

jeremyn commented Dec 21, 2016

I've updated the checklist through 414ac37, thanks. The remaining items are not finished because you didn't delete the requested comments.

Also, we like to squash-and-merge pull requests, which means we combine and rewrite pull requests in your name. Is that all right with you for this and any other pull requests you submit to us? Additionally, for this pull request, I want to delete all of your individual commits when I do the merge. Is that all right? (Please don't do that yourself, it might make it harder to review your remaining changes.)

@Jochen-A-Fuerbacher
Copy link
Contributor Author

Yes, you can squash-and-merge the pull request and delete the individual commits.

@jeremyn jeremyn merged commit 42d15ac into EFForg:master Dec 22, 2016
@jeremyn
Copy link
Contributor

jeremyn commented Dec 22, 2016

Thanks, merged.

@jeremyn jeremyn removed their assignment Dec 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants