This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Batch removal of duplicated test urls #14924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0WI
reviewed
Mar 17, 2018
<test url="http://panel.cloudatcost.com:12345/" /> | ||
<test url="http://panel.cloudatcost.com:59848/console.html" /> | ||
|
||
<rule from="^http:" to="https:" /> | ||
|
||
<test url="http://panel.cloudatcost.com/" /> | ||
<test url="http://members.cloudatcost.com/" /> | ||
<test url="http://panel.cloudatcost.com/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are even more duplicates.
Rulesets that don't pass our tests anyway should be excluded in this PR. Maybe some of them are already whitelisted and the hash needs to be updated. I think just updating the hash would be fine here. |
@J0WI thank for pointing out that some rulesets having more than 1 duplicates. I have updated the top comment and I will go through them later. |
Remove store.destructoid.com, gone from dns
Remove img.propellerads.com, gone from dns
Remove 20minro-ssl.wemfbox.ch, timeout Remove qs-ssl.wemfbox.ch, cert-chain Remove complicate rule for qs.wemfbox.ch
Remove app.greenhouseci.com, mismatch
Remove birdseye.cloud66.com, expired
Remove complicated rules for press.wpengine.com, destination gone from dns
Remove imaging.hdfcbank.com, cert-chain Remove punjabadds.hdfcbank.com, cert-chain
Remove complicated rules for c-nfa.jd.com, obsolete
Remove eleftheriako-giro-giro.espivblogs.net, timeout
Fenland.gov.uk.xml, Wandoujia.xml, luosimao.com.xml, tanx.com.xml required modifications too complicated to be performed in this PR.
|
Finally all tests passed. Thanks for fixing all those issues! |
This was referenced Mar 31, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hainish A dirty command is used to remove duplicated test urls found;
log.txt
is the Travis output of the failing test in #14660Block #14660
See https://stackoverflow.com/questions/23696871/how-to-remove-only-the-first-occurrence-of-a-line-in-a-file-using-sed
TODO
16 rulesets failed
fetch-test
6 rulesets failed
validations-test
2 rulesets having more than 1 duplicates