This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Extend duplicates check to rulesets with different platforms #14587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hainish, I can take care of the python3.6 transition for https://github.com/EFForg/https-everywhere/blob/master/test/validations/special/run.py in this PR if you wish. It would save us a git conflict. |
Bisaloo
changed the title
|
@Hainish, this should be ready for review |
|
@Hainish, it would be great if you could review this when you have some time. It's a pretty simple modification to the current process. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11440 for context (fix #11440).
I would like to get this merged when possible because @cschanaj statistics show that duplicate targets count increases (even though I regularly remove entries) and I don't think this is really intended. It is probably more of an oversight from contributors.
I am not super happy with the current clean up script but after giving it some thought, I don't think it is worth fixing it because I would like to see this whitelist totally removed at some point.