Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Tracking bug for issue bot improvements #14616

Closed
5 of 16 tasks
strugee opened this issue Feb 13, 2018 · 10 comments
Closed
5 of 16 tasks

Tracking bug for issue bot improvements #14616

strugee opened this issue Feb 13, 2018 · 10 comments

Comments

@strugee
Copy link
Contributor

strugee commented Feb 13, 2018

Type: code issue

This is a tracking bug collecting all the ideas that have been proposed for the issue format bot, in various issues. Feel free to comment below and I'll edit the description to add ideas to the list.

Issues with high impact and low work factor are prioritized higher.

@strugee
Copy link
Contributor Author

strugee commented Feb 13, 2018

/cc @Bisaloo

@Bisaloo
Copy link
Collaborator

Bisaloo commented Feb 13, 2018

It would also be useful if the bot could warn the OP when there is another open issue/PR with the same domain.

It would:

  • help prevent duplicates
  • ensure contributors fix all issues related to a specific domain where they open a PR
  • inform users that their issue may already be fixed in a pending PR
  • ...

This may be tricky though because it would require the bot to keep a list of domains and to scan all issues/PR every single time.

@strugee
Copy link
Contributor Author

strugee commented Feb 14, 2018

@Bisaloo that's a good idea. However GitHub doesn't provide a good API for issues search, at least not in APIv3. I think we should be able to just load all the open issues in memory though, if we don't keep any of the issue bodies and basically just map domain -> issue number(s). I'll have to measure the memory consumption but I think it'll be okay - although what if the issue list grows? There are ~500 open issues as of this writing.

strugee added a commit to strugee/https-everywhere that referenced this issue Feb 15, 2018
strugee added a commit to strugee/https-everywhere that referenced this issue Feb 15, 2018
Notably, replace localtunnel with smee for development,
since that's what upstream did.

Ref EFForg#14616
@Bisaloo
Copy link
Collaborator

Bisaloo commented Feb 18, 2018

  • Allow community members to ask the bot to label an issue as potentially outdated (not sure this is a good idea but would help people with write access find issues to close, see Handling old issues #13890 (comment))
  • Allow community members to ask the bot to add metadata to the issue description (Handling old issues #13890 (comment))

About this, I would like to be able to label:

  • CORS issues
  • MCB

Also, the bot should probably label all ruleset issues as such. Right now, we only know this because of Alexa ranks. And it only works if rank < 1M.

@strugee
Copy link
Contributor Author

strugee commented Feb 18, 2018

@Bisaloo see the second item in the list.

strugee added a commit to strugee/https-everywhere that referenced this issue Feb 20, 2018
strugee added a commit to strugee/https-everywhere that referenced this issue Mar 21, 2018
strugee added a commit to strugee/https-everywhere that referenced this issue May 16, 2018
@pipboy96
Copy link
Contributor

The bot seems to have been disabled.

@strugee
Copy link
Contributor Author

strugee commented Apr 16, 2019

Yeah, I'm curious what happened there? Did it fall over or were people not happy with the way it worked?

@pipboy96
Copy link
Contributor

@strugee Mostly the fact it wasn't well written and created spam comments. I want to try to fix it if possible, so it could be restarted.

@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 16, 2019

@strugee, my understanding it that it fell over and nobody bothered restarting it. You'd need to ask @zoracon for more info.

@pipboy96, wasn't the multiple comment issue fixed? I don't remember very well

@strugee
Copy link
Contributor Author

strugee commented Apr 16, 2019

Mostly the fact it wasn't well written and created spam comments. I want to try to fix it if possible, so it could be restarted.

If it was creating spam comments I wish someone would've pinged me so I could fix it. Unless you were referring to #13460? But that was fixed over a year and a half ago.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants