Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for client packages #47

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix for client packages #47

merged 1 commit into from
Oct 29, 2020

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Oct 29, 2020

It was using commas as separator in the list of Stratum 1 urls, this should be a semicolon.

@boegel
Copy link
Contributor

boegel commented Oct 29, 2020

@bedroge Any idea of how we could've caught this in CI?

@bedroge
Copy link
Collaborator Author

bedroge commented Oct 29, 2020

We need some CI that actually tests the client packages (by, for instance, just doing a ls), I'll open an issue for that.

@bedroge bedroge mentioned this pull request Oct 29, 2020
Closed
@boegel boegel merged commit 1b32155 into master Oct 29, 2020
@bedroge bedroge deleted the fix_client_packages branch October 29, 2020 16:19
@boegel boegel mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bedroge @boegel