Bot only reports moving to trash_bin when relevant #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Neves-P Looks look, but perhaps better test on a live bot to make 100% sure? |
|
@boegel , agreed! I'd like to try out in a live bot (but not the main bots). I should be able to try it on the dev.eessi.io bot, or make a new bot instance in RUG. I hope to have a bit of time to try it this week, if not I will do so early next week 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the bot will only write a comment when a PR is closed if any directories were actually moved to the
trash_bin. Without this, bots that didn't build anything but are listening on PRs will still comment that an empty list was moved to the trash bin directory.I have not yet tested this live on a bot build, but can do so on the dev.eessi.io bot
This PR is related to #290 but does fix it.