add function to determine comment id for a job and use it #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds function `determine_pr_comment_id` which reads the attribute `pr_comment_id` from the job's metadata file (all current bot instances already provide that attribute when creating the job's metadata file) - the function is then used when successful jobs are determined (in function `determine_successful_jobs`) and the comment id is added to a dictionary that contains information for each job - another function (`determine_tarballs_to_deploy`) adds the comment id to a dictionary storing information about jobs/tarballs to deploy
bedroge
approved these changes
Feb 13, 2024
bedroge
reviewed
Feb 13, 2024
| @@ -74,6 +75,26 @@ def determine_job_dirs(pr_number): | |||
| return job_directories | |||
|
|
|||
|
|
|||
| def determine_pr_comment_id(job_dir): | |||
There was a problem hiding this comment.
It would probably be good to implement a test for this function, but I see that we don't have any tests for the functions in tasks/deploy.py, so this can be done later for all of them.
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to sync bot codes used for EESSI and NESSI. It includes the following changes
determine_pr_comment_idwhich reads the attributepr_comment_idfrom the job's metadata file (all current bot instances already provide that attribute when creating the job's metadata file)determine_successful_jobs) and the comment id is added to a dictionary that contains information for each jobdetermine_tarballs_to_deploy) adds the comment id to a dictionary storing information about jobs/tarballs to deploys) with a more descriptive name (job)