Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added org info API #127

Merged
merged 11 commits into from
Jun 22, 2020
Merged

feat: Added org info API #127

merged 11 commits into from
Jun 22, 2020

Conversation

sahil9001
Copy link
Member

@sahil9001 sahil9001 commented Jun 7, 2020 •
edited
Loading

Fixes #120

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.
This commit adds the functionality to fetch the information about any
organisation by an authorised user, so that users can check the details
before joining them.

Type of Change: (Delete irrelevant options)

  • Code
  • Testing

Code/Quality Assurance Only (Delete irrelevant options)

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

(envteesco) sahil@laptop:~/Desktop/Projects/teesco-backend$ python manage.py test
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
..........................................................
----------------------------------------------------------------------
Ran 58 tests in 11.920s

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • Update Swagger documentation and the exported file at /docs folder
  • Update requirements.txt

Code/Quality Assurance

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

anshsrtv
anshsrtv reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@anshsrtv anshsrtv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @sahil9001 🚀 ... I have commented on some parts of code.. Please check them.

org/urls.py Outdated Show resolved Hide resolved
org/views.py Outdated Show resolved Hide resolved
sahil9001 added 2 commits June 14, 2020 09:18
@sahil9001
modified: org/responses.py
1af07f1 
	modified:   org/urls.py
	modified:   org/views.py
	new file:   tests/org/tests_org_info.py
@sahil9001
feat: Added org info API
ef67b89 
This commit adds the functionality to fetch the information about any
organisation by an authorised user, so that users can check the details
before joining them.

Fixes ECellNitrr#120
@sahil9001 sahil9001 requested a review from anshsrtv June 15, 2020 05:02
@sahil9001
Copy link
Member Author

@naveennvrgup Can we merge this now?

naveennvrgup
naveennvrgup requested changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@naveennvrgup naveennvrgup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Nice test cases 🔥
  2. Please fix conflicts

org/views.py Outdated Show resolved Hide resolved
org/views.py Outdated Show resolved Hide resolved
org/views.py Outdated Show resolved Hide resolved
sahil9001 and others added 9 commits June 18, 2020 20:37
@sahil9001 @naveennvrgup
Update org/views.py
d304cec 
Co-authored-by: Naveen Sundar <[email protected]>
@sahil9001 @naveennvrgup
Update org/views.py
d3765bb 
Co-authored-by: Naveen Sundar <[email protected]>
@sahil9001 @naveennvrgup
Update org/views.py
c8aeaa2 
Co-authored-by: Naveen Sundar <[email protected]>
@sahil9001
Merge branch 'dev' into 120_org_info_api
a6ea1df
@sahil9001
modified: org/responses.py
1963e3b 
	modified:   org/urls.py
	modified:   org/views.py
	new file:   tests/org/tests_org_info.py
@sahil9001
feat: Added org info API
864d699 
This commit adds the functionality to fetch the information about any
organisation by an authorised user, so that users can check the details
before joining them.

Fixes ECellNitrr#120
@sahil9001
modified: org/urls.py
480c920
@sahil9001
Merge branch '120_org_info_api' of https://github.com/sahil9001/teesc…
87e8c5f 
…o-backend into 120_org_info_api
@sahil9001
modified: org/responses.py
0166179 
	modified:   org/views.py
naveennvrgup
naveennvrgup approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@naveennvrgup naveennvrgup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Great job @sahil9001
  2. tested locally works as expected

@naveennvrgup naveennvrgup merged commit 227b764 into ECellNitrr:dev Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveennvrgup naveennvrgup naveennvrgup approved these changes

@priyanshisharma priyanshisharma Awaiting requested review from priyanshisharma

@sumit-badsara sumit-badsara Awaiting requested review from sumit-badsara

@anshsrtv anshsrtv Awaiting requested review from anshsrtv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

org info API
3 participants
@sahil9001 @naveennvrgup @anshsrtv