Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake/CTest: Opt-in Disable Signal Handling #5550

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 10, 2025

In IDEs, we want to attach debuggers to CTest runs. This needs an option to disable signal handling from AMReX to work.

In IDEs, we want to attach debuggers to CTest runs. This needs
an option to disable signal handling from AMReX to work.
@ax3l ax3l added component: documentation Docs, readme and manual component: tests Tests and CI install labels Jan 10, 2025
@ax3l ax3l requested a review from EZoni January 10, 2025 18:51
Examples/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated
mark_as_advanced(WarpX_TEST_FPETRAP)

# Advanced option to run CI tests with the -g compile option
option(WarpX_TEST_DEBUG "Run CI tests with the -g compile option" OFF)
option(WarpX_TEST_DEBUG "Compile tests with -g1 for symbols (for CI)" OFF)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ax3l

Would you like to rename WarpX_TEST_DEBUG in this PR or in a separate one? If you would like to do it in this PR, feel free to let me know if you want me to do the change (after discussing the new name with you, of course), in case you have other more important stuff on your plate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the docs at https://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html, maybe we could rename this simply WarpX_TEST_DEBUG_INFO, more verbose but less generic than WarpX_TEST_DEBUG?

Copy link
Member Author

@ax3l ax3l Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about WarpX_TEST_DEBUG_SYMBOLS?

Technically, it is even WarpX_DEBUG_SYMBOLS.

Copy link
Member Author

@ax3l ax3l Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe WarpX_MINIMAL_DEBUG_SYMBOLS or WarpX_BACKTRACE_INFO?

image

@EZoni

This comment was marked as resolved.

@EZoni
Copy link
Member

EZoni commented Jan 15, 2025

I think this replaces #5259.

@EZoni EZoni mentioned this pull request Jan 15, 2025
2 tasks
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. @ax3l, feel free to review my latest changes and confirm if this looks good to you too, so we can enable automerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants