Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing Include Guards (FWD) #2226

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 23, 2021

All header files need include guards to avoid double definitions.

Follow-up to #2124 & #1947
(First seen as an issue in #2223)

All header files need include guards to avoid double definitons.
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: core Core WarpX functionality labels Aug 23, 2021
@ax3l ax3l requested review from atmyers and lucafedeli88 August 23, 2021 23:40
@ax3l ax3l force-pushed the fix-missingIncludeGuards branch from e9c42b6 to f337786 Compare August 24, 2021 00:16
@ax3l ax3l force-pushed the fix-missingIncludeGuards branch from f337786 to 7ad4924 Compare August 25, 2021 06:19
Copy link
Member

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@lucafedeli88 lucafedeli88 merged commit de12302 into ECP-WarpX:development Aug 25, 2021
@ax3l ax3l deleted the fix-missingIncludeGuards branch August 25, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: core Core WarpX functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants