Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 で PHPUnit が失敗する不具合を回避 #853

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

seasoftjapan
Copy link
Contributor

全体実行で一部が FAILURES となっていた。グローバル変数が消失(若しくは汚染)していたと考えられる。 PHP 8.1 で発現を確認。PHP 7.4 では発生しない。PHPUnit のバージョンが古いのが原因か。 https://xoops.ec-cube.net/modules/newbb/viewtopic.php?topic_id=28010&forum=4

全体実行で一部が FAILURES となっていた。グローバル変数が消失(若しくは汚染)していたと考えられる。
PHP 8.1 で発現を確認。PHP 7.4 では発生しない。PHPUnit のバージョンが古いのが原因か。
https://xoops.ec-cube.net/modules/newbb/viewtopic.php?topic_id=28010&forum=4
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.21%. Comparing base (1101e98) to head (7631399).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files          75       75           
  Lines        8913     8913           
=======================================
  Hits         4921     4921           
  Misses       3992     3992           
Flag Coverage Δ
tests 55.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seasoftjapan
Copy link
Contributor Author

作業中に実装中途のものを誤って master に push してしまい (e1042d9)、revert しました (7b80da7)。

@shinya
Copy link
Contributor

shinya commented Mar 6, 2024

ありがとうございます。マージします。

@shinya shinya merged commit 9fb10ef into master Mar 6, 2024
5 checks passed
@seasoftjapan seasoftjapan deleted the seasoft-phpunit-20240302 branch May 29, 2024 03:49
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants