Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions にcheckoutを追加(※Auto Merge) #835

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

shinya
Copy link
Contributor

@shinya shinya commented Feb 6, 2024

以前、申請したPRである #827 において、
failed to run git: fatal: not a git repository (or any of the parent directories): .git
というエラーが発生。リポジトリのチェックアウトが必要なのにできていないというミスがあったので、追加で対応を行いました。

具体的には、承認処理が行われる前にチェックアウトのstepを追加しています。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d68e826) 55.38% compared to head (4fa87c1) 55.38%.
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   55.38%   55.38%           
=======================================
  Files          75       75           
  Lines        8908     8908           
=======================================
  Hits         4934     4934           
  Misses       3974     3974           
Flag Coverage Δ
tests 55.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotani1111 dotani1111 merged commit 6d5a5b9 into EC-CUBE:master Feb 7, 2024
3 checks passed
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants