setasign/fpdf の更新に伴う修正 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpdf-1.8.5 は fpdi-2.x を使用する必要があるが、システム要件が PHP5.6+ となってしまう。 fpdf-1.8.4 の _out() メソッドを SC_Helper_FPDI クラスに移植することで、 fpdi-1.6.2 でも動作する
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 55.33% 55.33%
=======================================
Files 75 75
Lines 8892 8902 +10
=======================================
+ Hits 4920 4926 +6
- Misses 3972 3976 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nanasess
changed the title
nobuhiko
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#638 において、 PDF 生成時にシステムエラーが発生していた。
fpdf-1.8.5 は fpdi-2.x を使用する必要があるが、システム要件が PHP5.6+となってしまう。
fpdf-1.8.4 の _out() メソッドを SC_Helper_FPDI クラスに移植することで、fpdi-1.6.2 にも対応する