Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanasess/mdb2 を使用する #547

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Apr 11, 2022

  • refs dependabot のエラー #542
  • pear/MDB2 をフォークした nanasess/mdb2 を使用するよう修正
    • silverorange/mdb2: "2.5.2-b.5" は、minimum-stability: beta 扱いなので dependabot がエラーになってしまう
      • 2.6.x 以降は変更が大きすぎて動作しないため、 pear/MDB2 からフォークする

@nanasess
Copy link
Contributor Author

Windows 環境でのエラーは #526 で対応済み

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Apr 20, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess
composer.lockのコンフリクト解消おねがいできますでしょうか。

@nanasess
Copy link
Contributor Author

@chihiro-adachi 解消しました

@codecov-commenter
Copy link

Codecov Report

Merging #547 (aea7702) into master (2f6eb97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files          76       76           
  Lines        9058     9058           
=======================================
  Hits         4949     4949           
  Misses       4109     4109           
Flag Coverage Δ
tests 54.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6eb97...aea7702. Read the comment docs.

@chihiro-adachi chihiro-adachi merged commit f1cd141 into EC-CUBE:master May 12, 2022
@nanasess nanasess deleted the use-mdb2 branch October 3, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants