Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP7 での警告を修正 #285

Merged
merged 12 commits into from
Jul 30, 2019
Merged

PHP7 での警告を修正 #285

merged 12 commits into from
Jul 30, 2019

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jun 25, 2019 •
edited
Loading

  • admin/main_frame.tpl の Head COLUMN は不要
  • count での null チェックを修正
  • 型変換の警告を修正
  • セッション開始後に session_set_save_handler がコールされていたのを修正

@coveralls
Copy link

coveralls commented Jun 25, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 43.011% when pulling 12e345c on nanasess:fix-warnings into 7f77a44 on EC-CUBE:improve/php7.

@kazumiiiiiiiiiii kazumiiiiiiiiiii added this to the 2.17.0 milestone Jul 2, 2019
@kazumiiiiiiiiiii
Copy link
Contributor

コンフリクトの修正をお願いします。

@nanasess nanasess mentioned this pull request Jul 3, 2019
Merged
@nanasess nanasess mentioned this pull request Jul 19, 2019
Merged
@chihiro-adachi chihiro-adachi merged commit eedab98 into EC-CUBE:improve/php7 Jul 30, 2019
@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます。マージしました。

@nanasess nanasess mentioned this pull request Jan 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
enhancement ready-for-merge
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nanasess @coveralls @kazumiiiiiiiiiii @chihiro-adachi @nobuhiko