Fix issue of EC-CUBE#93 商品一覧の価格順並び替えが登録されていない商品規格に影響される #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
del_flgを考慮し登録されていない規格の商品価格を含めないように修正。 refs EC-CUBE#93
added 2 commits
April 22, 2019 03:37
…arrOrderDataの設定による並び順()でのテストにこけていたのを修正。 削除された商品の場合にnullになるが、nullの並びはPostgreSQLだと下位にMySQLだと上位に扱われる差異があった。 ただ、削除された商品はそもそも検索対象でないのでfindProductIdsOrderの結果からも外すようにして修正。
nanasess
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
del_flgを考慮し登録されていない規格の商品価格を含めないように修正。
#93