Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test 以下のテストを tests 以下に移植 #190

Merged
merged 9 commits into from
Apr 27, 2018

Conversation

nanasess
Copy link
Contributor

  • test 以下のテストは永らくメンテされていないので削除
  • test 以下のテストで、動作するものは tests 以下に移植
  • PHP7.2 でテストが通るよう修正

@coveralls
Copy link

coveralls commented Apr 24, 2018

Coverage Status

Coverage decreased (-0.02%) to 22.458% when pulling 068b9b5 on nanasess:remove-test-directory into 3fc6ab3 on EC-CUBE:improve/php7.

@nanasess nanasess changed the title test 以下のテストを tests 以下に移植 [WIP] test 以下のテストを tests 以下に移植 Apr 24, 2018
@nanasess
Copy link
Contributor Author

nanasess commented Apr 24, 2018

現状の構成では MySQL の対応が辛いので見直します...

@nanasess nanasess force-pushed the remove-test-directory branch from 542a4ab to 1e3360b Compare April 25, 2018 00:46
@nanasess nanasess force-pushed the remove-test-directory branch from 79d09bc to a1354ef Compare April 25, 2018 09:48
@nanasess nanasess changed the title [WIP] test 以下のテストを tests 以下に移植 test 以下のテストを tests 以下に移植 Apr 25, 2018
@nanasess
Copy link
Contributor Author

現状の構成では MySQL の対応が辛いので見直します...

MySQL でも動作するよう改善しました。

@chihiro-adachi chihiro-adachi added this to the 2.17.0 milestone Apr 27, 2018
@chihiro-adachi chihiro-adachi merged commit 452c2db into EC-CUBE:improve/php7 Apr 27, 2018
@nanasess nanasess deleted the remove-test-directory branch May 23, 2019 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants