Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

入力が無い場合にも MIN_LENGTH_CHECK がエラー判定となってしまうのを修正 #1112

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

nanasess
Copy link
Contributor

Fixes #115

MIN_LENGTH_CHECK は EC-CUBE本体では使用されていない模様

@nanasess nanasess added this to the 2.18(仮) milestone Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.61%. Comparing base (aab3658) to head (a4ab1b2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   50.60%   50.61%   +0.01%     
==========================================
  Files          80       80              
  Lines       10258    10261       +3     
==========================================
+ Hits         5191     5194       +3     
  Misses       5067     5067              
Flag Coverage Δ
tests 50.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess enabled auto-merge December 26, 2024 08:29
@nanasess nanasess merged commit 8c8e0bb into EC-CUBE:master Jan 7, 2025
108 checks passed
@nanasess nanasess deleted the fix-min_length_check branch January 7, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

入力が無い場合にも SC_CheckError::MIN_LENGTH_CHECK() がエラー検出してしまう。
2 participants