fixed #554 アンカーがある場合はnoneしない #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
=======================================
Coverage 51.63% 51.63%
=======================================
Files 80 80
Lines 10223 10223
=======================================
Hits 5279 5279
Misses 4944 4944
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
php-cs-fixer厳しい！ルールが違うのか |
|
@nobuhiko |
|
@nanasess です、みにくくてすみません |
nanasess
requested changes
Dec 23, 2024
| || SC_Utils_Ex::isBlank($arrSubProductData['sub_comment'.$i]) == false | ||
| || SC_Utils_Ex::isBlank($arrSubProductData['sub_image'.$i]) == false | ||
| || SC_Utils_Ex::isBlank($arrSubProductData['sub_large_image'.$i]) == false | ||
| || SC_Utils_Ex::isBlank($arrSubProductData['temp_sub_image'.$i]) == false | ||
| || SC_Utils_Ex::isBlank($arrSubProductData['temp_sub_large_image'.$i]) == false | ||
| || $arrSubProductData['image_key'] == 'sub_image'.$i |
There was a problem hiding this comment.
Suggested change
| || $arrSubProductData['image_key'] == 'sub_image'.$i | |
| || $arrSubProductData['image_key'] == 'sub_image'.$i | |
| || $arrSubProductData['image_key'] == 'sub_large_image'.$i |
最初にサブ拡大画像にアップロードすると閉じてしまったので、'sub_large_image'.$i も追加でお願いします
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554