Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net_SMTP更新 #1089

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Net_SMTP更新 #1089

merged 5 commits into from
Dec 20, 2024

Conversation

nobuhiko
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.70%. Comparing base (7721607) to head (ef8ce0c).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   51.70%   51.70%           
=======================================
  Files          80       80           
  Lines       10217    10217           
=======================================
  Hits         5283     5283           
  Misses       4934     4934           
Flag Coverage Δ
tests 51.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess added this to the 2.18(仮) milestone Dec 19, 2024
@nanasess
Copy link
Contributor

Net_Socket に手を入れているので互換性を要確認。変更があれば記載する
#558

@nanasess nanasess enabled auto-merge December 19, 2024 08:53
@nanasess
Copy link
Contributor

どちらでも動作することを確認

  • StartTLS: SMTP_HOST=example.com, SMTP_PORT=587
  • SSL: SMTP_HOST=ssl://example.com, SMTP_PORT=465

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess nanasess merged commit 110f5ca into EC-CUBE:master Dec 20, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants