Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on PHP8 #1077

Merged
merged 8 commits into from
Dec 24, 2024

Apply php-cs-fixer

fe901da
Select commit
Loading
Failed to load commit list.
Merged

Fix warning on PHP8 #1077

Apply php-cs-fixer
fe901da
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 24, 2024 in 0s

50.94% (-0.70%) compared to 4b3b997

View this Pull Request on Codecov

50.94% (-0.70%) compared to 4b3b997

Details

Codecov Report

Attention: Patch coverage is 73.01587% with 34 lines in your changes missing coverage. Please review.

Project coverage is 50.94%. Comparing base (4b3b997) to head (fe901da).

Files with missing lines Patch % Lines
data/class/SC_Initial.php 0.00% 11 Missing ⚠️
data/class/helper/SC_Helper_HandleError.php 0.00% 6 Missing ⚠️
data/class/SC_Response.php 50.00% 5 Missing ⚠️
...ss/sessionfactory/SC_SessionFactory_UseRequest.php 0.00% 4 Missing ⚠️
data/class/SC_ClassAutoloader.php 50.00% 2 Missing ⚠️
data/class/plugin/SC_Plugin_Util.php 0.00% 2 Missing ⚠️
...ass/sessionfactory/SC_SessionFactory_UseCookie.php 0.00% 2 Missing ⚠️
data/class/helper/SC_Helper_Session.php 0.00% 1 Missing ⚠️
data/class/plugin/SC_Plugin_Installer.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   51.64%   50.94%   -0.70%     
==========================================
  Files          80       80              
  Lines       10224    10256      +32     
==========================================
- Hits         5280     5225      -55     
- Misses       4944     5031      +87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov