Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on PHP8 #1077

Merged
merged 8 commits into from
Dec 24, 2024
+230 −175

Fix Warning `Undefined array key "subsetted" on [/path/to/vendor/seta…

58c4a45
Select commit
Loading
Failed to load commit list.
Merged

Fix warning on PHP8 #1077

Fix Warning `Undefined array key "subsetted" on [/path/to/vendor/seta…
58c4a45
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 17, 2024 in 0s

50.58% (-1.10%) compared to 27be918

View this Pull Request on Codecov

50.58% (-1.10%) compared to 27be918

Details

Codecov Report

Attention: Patch coverage is 70.07874% with 38 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (27be918) to head (58c4a45).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
data/class/SC_Initial.php 0.00% 11 Missing ⚠️
data/class/helper/SC_Helper_HandleError.php 0.00% 6 Missing ⚠️
data/class/SC_Response.php 50.00% 5 Missing ⚠️
...ss/sessionfactory/SC_SessionFactory_UseRequest.php 0.00% 4 Missing ⚠️
data/class/util/GC_Utils.php 0.00% 4 Missing ⚠️
data/class/SC_ClassAutoloader.php 50.00% 2 Missing ⚠️
data/class/plugin/SC_Plugin_Util.php 0.00% 2 Missing ⚠️
...ass/sessionfactory/SC_SessionFactory_UseCookie.php 0.00% 2 Missing ⚠️
data/class/helper/SC_Helper_Session.php 0.00% 1 Missing ⚠️
data/class/plugin/SC_Plugin_Installer.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   51.67%   50.58%   -1.10%     
==========================================
  Files          80       80              
  Lines       10224    10257      +33     
==========================================
- Hits         5283     5188      -95     
- Misses       4941     5069     +128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov