Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MySQL8.4 with utf8mb4 #1044

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Use MySQL8.4 with utf8mb4 #1044

merged 4 commits into from
Dec 18, 2024

Conversation

nanasess
Copy link
Contributor

This pull request includes an update to the MySQL service configuration in the docker-compose.mysql.yml file. The most important change is upgrading the MySQL version and adjusting the character set and collation settings.

MySQL service configuration update:

  • docker-compose.mysql.yml: Upgraded MySQL image from mysql:8.0 to mysql:8.4 and changed the character set to utf8mb4 and collation to utf8mb4_general_ci.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.67%. Comparing base (c51b7d9) to head (e563295).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   51.67%   51.67%           
=======================================
  Files          80       80           
  Lines       10224    10224           
=======================================
  Hits         5283     5283           
  Misses       4941     4941           
Flag Coverage Δ
tests 51.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
@seasoftjapan
Copy link
Contributor

作成されるデータベースは utf8mb3 のようですが、意図する動作でしょうか?

$ mysql --host 127.0.0.1 --port 13306 --user eccube_db_user -p eccube_db -e 'SELECT @@character_set_database, @@collation_database;'
+--------------------------+----------------------+
| @@character_set_database | @@collation_database |
+--------------------------+----------------------+
| utf8mb3                  | utf8mb3_general_ci   |
+--------------------------+----------------------+

以下が原因と推察しています。
https://github.com/nanasess/ec-cube2/blob/ebf1770e441dec1b89fbc52a8f9cd7be85a84b66/eccube_install.sh#L270

@nanasess
Copy link
Contributor Author

@seasoftjapan
すみません、こちらは意図しておりませんでした。 eccube_install.sh の方も修正入れますね

@nanasess nanasess merged commit afe32dd into EC-CUBE:master Dec 18, 2024
107 checks passed
@nanasess nanasess deleted the use-mysql8.4 branch December 18, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants