Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpackの軽量化 #1043

Merged
merged 4 commits into from
Oct 29, 2024
Merged

webpackの軽量化 #1043

merged 4 commits into from
Oct 29, 2024

Conversation

nobuhiko
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.72%. Comparing base (8f5b661) to head (1399f72).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1043   +/-   ##
=======================================
  Coverage   51.72%   51.72%           
=======================================
  Files          80       80           
  Lines       10202    10202           
=======================================
  Hits         5277     5277           
  Misses       4925     4925           
Flag Coverage Δ
tests 51.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess
Copy link
Contributor

Copilot actions による説明

This pull request focuses on modernizing the JavaScript codebase by switching from CommonJS to ES6 module syntax, updating dependencies, and improving code formatting for better readability and maintainability. The most important changes include updating imports, upgrading dependencies, and enhancing code formatting.

Modernization and Dependency Updates:

  • Switch from CommonJS to ES6 Modules: Replaced require statements with import statements for better compatibility with modern JavaScript standards in data/eccube.js.
  • Dependency Updates: Updated several dependencies in package.json to their latest versions, including jquery to 3.7.1 and jquery-migrate to 3.5.2.

Code Formatting Improvements:

  • Consistent Code Formatting: Improved code formatting by adding line breaks and indentation for better readability in multiple sections of data/eccube.js. [1] [2] [3]
  • Trailing Comma Addition: Added trailing commas in object literals and function parameters to adhere to modern JavaScript coding standards in data/eccube.js. [1] [2]

Build Configuration:

  • Webpack Configuration Update: Added TerserPlugin to the webpack.config.js for better minification and optimization of the production build.

@nanasess
Copy link
Contributor

@nobuhiko
yarn install --frozen-lockfile を実行すると、以下のようなエラーになります。

error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.

package.json で "packageManager": "[email protected]..." としているためだと思われますが、以下どうしましょうかね。

  1. corepack の利用をやめる
  2. yarn v1 形式の yarn.lock にする

@nobuhiko
Copy link
Contributor Author

あー、yarnのバージョンが合ってないのか
やっぱyarnやめちゃいたいですね

@nanasess
Copy link
Contributor

yarn やめても問題ないと思うんですが、いきなりやめると少々混乱しそうです。
一定期間共存できたりしないですかね🤔

@nanasess nanasess enabled auto-merge October 29, 2024 01:17
Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess nanasess merged commit e4af84a into EC-CUBE:master Oct 29, 2024
106 checks passed
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants