買い物プロセス ゲスト購入でお客様情報入力へ戻ると生年月日が補完されない #1008 #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
=======================================
Coverage 56.23% 56.23%
=======================================
Files 75 75
Lines 9046 9046
=======================================
Hits 5087 5087
Misses 3959 3959
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nanasess
requested changes
Sep 29, 2024
data/class/SC_FormParam.php
Outdated
| $this->setValue($day_key, $d); | ||
|
|
||
| // Smarty3以降は月日が1桁の場合、0埋めされていると補完されないため0を除去する | ||
| $objDate = new DateTime($db_date); |
There was a problem hiding this comment.
細かいところですが、 DateTimeImmutable にしておきましょうか。
Suggested change
| $objDate = new DateTime($db_date); | |
| $objDate = new DateTimeImmutable($db_date); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1008