Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtb_allowed_tag の初期値に不足 #224

Closed
seasoftjapan opened this issue Aug 18, 2018 · 6 comments
Closed

mtb_allowed_tag の初期値に不足 #224

seasoftjapan opened this issue Aug 18, 2018 · 6 comments
Labels
discussion enhancement
Milestone
2.18(仮)

Comments

@seasoftjapan
Copy link
Contributor

seasoftjapan commented Aug 18, 2018 •
edited
Loading

運営サイドで追加しているのをよく見かけるのを、記憶の範囲で。

  • span
  • tbody
  • thead
  • tfoot (見かけないけど一応)
  • th
  • ul
  • ol
  • dl
  • dt
  • dd
@seasoftjapan seasoftjapan mentioned this issue Aug 18, 2018
Closed
seasoftjapan added a commit to seasoftjapan/eccube-2_13 that referenced this issue Aug 18, 2018
@seasoftjapan
[fix] refs EC-CUBE#224 mtb_allowed_tag の初期値に不足
86b6462
@coveralls coveralls mentioned this issue Aug 18, 2018
Closed
@ryo-endo ryo-endo added this to the 2.17.0 milestone Aug 20, 2018
@so-amuamu
Copy link

html5のリファレンスより、定義を網羅するようにしましょう
sectionなど多数足すべきものがあると思われます

@nobuhiko
Copy link
Contributor

入れちゃいけないタグを弾く方式じゃダメなんですかね？
入れちゃいけないタグがなんなのかよくわからないですが

@so-amuamu
Copy link

確かにブラックリスト方式の方が現状は良さそう・・・

@seasoftjapan
Copy link
Contributor Author

ブラックリスト化するとして、この Issue で扱うのか、別とするのか、どうでしょうか?

また、ブラックリストに初期登録する要素を、叩き台として列挙してみます。

  • script
  • html
  • body
  • head
  • title
  • meta
  • frame
  • frameset
  • object
  • embed
  • param
  • form
  • input
  • select
  • textarea
  • button

@so-amuamu
Copy link

仕様が180度変わる（ホワイトリスト方式→ブラックリスト方式）のは直近では避けるとして
今回はタグを追加して本件は終わりにし、ブラックリスト方式にするのは将来検討としたいです。

@seasoftjapan seasoftjapan mentioned this issue Sep 11, 2018
Closed
@coveralls coveralls mentioned this issue Sep 11, 2018
Merged
seasoftjapan added a commit to seasoftjapan/eccube-2_13 that referenced this issue Jun 19, 2019
@seasoftjapan
Merge remote-tracking branch 'remotes/Lockon/improve/php7' into EC-CU…
b0fe10d 
…BE#224
kazumiiiiiiiiiii pushed a commit that referenced this issue Jul 2, 2019
@seasoftjapan
Merge branch '#224' into improve/php7
964b24d
kazumiiiiiiiiiii added a commit that referenced this issue Jul 2, 2019
@kazumiiiiiiiiiii
Merge pull request #231 from seasoftjapan/#224
5c7aca2 
#224
@chihiro-adachi chihiro-adachi modified the milestones: 2.17.0, 2.17.1 Oct 31, 2019
@ryo-endo ryo-endo modified the milestones: 2.17.1, 2.17.2 Jun 29, 2020
@nanasess nanasess modified the milestones: 2.17.2, 2.17.3 Mar 1, 2022
@nanasess
Copy link
Contributor

#231 で初期値追加済みなのでクローズします

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement
Projects
None yet
Milestone
2.18(仮)
Development

No branches or pull requests
6 participants
@nobuhiko @nanasess @seasoftjapan @chihiro-adachi @so-amuamu @ryo-endo