fontawesomeにintegrity追加 #5969
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,8 +16,8 @@ file that was distributed with this source code. | |
| <meta name="eccube-csrf-token" content="{{ csrf_token(constant('Eccube\\Common\\Constant::TOKEN_NAME')) }}"> | ||
| <title>{{ block('sub_title') }} {{ block('title') }} - {{ BaseInfo.shop_name }}</title> | ||
| <link rel="icon" href="{{ asset('assets/img/favicon.ico', 'admin') }}"> | ||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/all.css" integrity="sha384-mzrmE5qonljUremFsqc01SB46JvROS7bZs3IO2EmfFsd15uHvIt+Y8vEf7N7fWAU" crossOrigin="anonymous"> | ||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/v4-shims.css" integrity="sha384-mzrmE5qonljUremFsqc01SB46JvROS7bZs3IO2EmfFsd15uHvIt+Y8vEf7N7fWAU" crossOrigin="anonymous"> | ||
|
There was a problem hiding this comment. v4-shims.cssのハッシュ値はall.cssと同じ値ですが問題ないでしょうか？ There was a problem hiding this comment. ハッシュ値は再度計算したものに差し替えいたします。 There was a problem hiding this comment. @Atsu0601 There was a problem hiding this comment. |
||
| <link rel="stylesheet" href="{{ asset('assets/css/bootstrap.css', 'admin') }}"> | ||
| <link rel="stylesheet" href="{{ asset('assets/css/app.css', 'admin') }}"> | ||
| <script src="{{ asset('admin.bundle.js', 'bundle') }}"></script> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crossOrigin->crossoriginでお願いします。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらも変更致します。ありがとうございます。