-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2Eテストが落ちる問題の修正 #4921
Merged
Merged
E2Eテストが落ちる問題の修正 #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
force-pushed
the
fix-e2e
branch
from
February 16, 2021 06:19
b9866aa
to
c1768aa
Compare
chihiro-adachi
changed the title
[WIP] tempusdominus-bootstrap-4.jsを読み込めない場合がある問題の対応
E2Eテストが落ちる問題の修正
Feb 16, 2021
11 tasks
Chrome, Firefox, Safari で datetimepickerの動作確認をして問題ありませんでした。 |
@chihiro-adachi |
okazy
added
affected:template
フロントテンプレートの変更
javascript
Pull requests that update Javascript code
labels
Feb 17, 2021
okazy
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome, Safari, Firefox で動作確認して問題ありませんでした!
画面によって実装が違うのが気になりますが・・・
ありがとうございます!マージしました。 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affected:template
フロントテンプレートの変更
bug:Low
javascript
Pull requests that update Javascript code
Status: ready-for-merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
E2Eテストが落ちる問題を修正しました。
方針(Policy)
実装に関する補足(Appendix)
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目