-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
プラグインで Symfony Bundle を利用可能にする(experimental/plugin_bundle ブランチの取り込み) #4664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
プラグイン削除時のMappingExceptionを回避
> Symfony\Component\Debug\Exception\ContextErrorException: Notice: Undefined index: > entity-namespaces in /home/runner/work/ec-cube/ec-cube/src/Eccube/Service/PluginContext.php:87
This reverts commit b487937.
This reverts commit b487937.
PHP 7.1.3を超えるバージョンを必要とするプラグインを安全にインストールできるようにする
Fix PHP_VERSION
Remove extra tables
PHP 7.1.3を超えるバージョンを必要とするプラグインを安全にインストールできるようにする
Bundle に依存するプラグインの E2Eテスト追加
…ndle # Conflicts: # codeception/acceptance/EA10PluginCest.php
4.0 ブランチを experimental/plugin_bundle ブランチへ取り込み(コンフリクト解消)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
experimental/plugin_bundle ブランチにてプラグインで Symfony Bundle を利用可能にするための開発がされてきました。
Web API プラグインの開発とともに動作の確認もできましたので、4.0ブランチに取り込めればと思います。
experimental/plugin_bundle の主な対応は以下
対応の詳細はそれぞれのプルリクを参照
方針(Policy)
プラグインで Symfony Bundle が利用できるようにEC-CUBEを拡張
実装に関する補足(Appendix)
機能追加のみで互換性を損なう処理は追加されていない
テスト(Test)
E2Eテストを追加
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目