-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeFileSessionHandlerの引数へSessionのsave_pathを設定 #4572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanasess
approved these changes
Jun 12, 2020
11 tasks
chihiro-adachi
approved these changes
Jun 12, 2020
AppVeyor が落ちてるのはガチャなので無視してよさそうです |
Closed
UnitTestはTravisが通っているので問題ないかと思います。 Codeception (ubuntu-18.04, 7.3, pgsql, admin01)
|
okazy
approved these changes
Jun 12, 2020
こちらデグレのため4.0.4に取り込みます。 |
ありがとうございます。取り込みました。 |
nanasess
added a commit
to nanasess/ec-cube
that referenced
this pull request
Jun 15, 2020
okazy
added a commit
to okazy/ec-cube
that referenced
this pull request
Jun 22, 2020
11 tasks
ryo-endo
added a commit
that referenced
this pull request
Jun 29, 2020
#4572 でセッションの挙動が修正されて不要になった記述を削除
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
セッションの保存先が変更される問題を修正
#4571
テスト(Test)
システム情報より、session.save_pathが意図したパスへ変わることを確認
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目