Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVA-3681 - New process to override BioSamples created in NCBI #224

Merged
merged 7 commits into from
Oct 22, 2024
Merged

EVA-3681 - New process to override BioSamples created in NCBI #224

merged 7 commits into from
Oct 22, 2024

Conversation

tcezard
Copy link
Member

@tcezard tcezard commented Oct 16, 2024

No description provided.

apriltuesday
apriltuesday reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Biosamples is still having issues for the tests... meanwhile I think this looks fine, just a couple suggestions.

bin/modify_existing_sample.py Outdated Show resolved Hide resolved
tests/test_biosamples_submission.py Outdated Show resolved Hide resolved
tests/test_biosamples_submission.py Outdated Show resolved Hide resolved
nitin-ebi
nitin-ebi approved these changes Oct 18, 2024
View reviewed changes
eva_submission/biosample_submission/biosamples_submitters.py Outdated Show resolved Hide resolved
tests/test_biosamples_submission.py Outdated Show resolved Hide resolved
@tcezard tcezard requested a review from apriltuesday October 22, 2024 15:10
apriltuesday
apriltuesday approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tcezard tcezard merged commit 4cb6c27 into EBIvariation:master Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitin-ebi nitin-ebi nitin-ebi approved these changes

@apriltuesday apriltuesday apriltuesday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcezard @apriltuesday @nitin-ebi