EVA-3533 - Initial version of an orchestrator for submission processing #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitin-ebi
approved these changes
Jun 26, 2024
apriltuesday
approved these changes
Jul 2, 2024
|
|
||
| def process_submissions(): | ||
|
|
||
| scanner = SubmissionScanner() |
There was a problem hiding this comment.
Should this be NewSubmissionScanner?
| from retry import retry | ||
|
|
||
|
|
||
| def _url_build(*args, **kwargs): |
There was a problem hiding this comment.
Maybe add a docstring stating that args will be used as path params and kwargs as query params
| auth = (cfg.query('submissions', 'webservice', 'admin_username'), cfg.query('submissions', 'webservice', 'admin_password')) | ||
| response = requests.put(url, auth=auth) | ||
| response.raise_for_status() | ||
| return response.json() |
There was a problem hiding this comment.
This is fine for the initial version but I would reiterate what I wrote in the second half of this comment about a client class for the submission-ws. This way all our Python code can use the web service uniformly, just configured using admin credentials when necessary.
Co-authored-by: April Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.