Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hifiadapterfilt #69

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Hifiadapterfilt #69

wants to merge 3 commits into from

Conversation

Ge94
Copy link
Member

@Ge94 Ge94 commented Oct 21, 2024

As @mberacochea suggested I will add the container to bioconda and then change the module here.

vagkaratzas
vagkaratzas requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Be sure to run the linters locally, so all the test actions pass on GitHub. I would suggest adding just another test that utilises the {args}, just to see with a glance some extra options

modules/ebi-metagenomics/hifiadapterfilt/environment.yml
- conda-forge
- bioconda
dependencies:
- "YOUR-TOOL-HERE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you have the bioconda, remember to fill this

modules/ebi-metagenomics/hifiadapterfilt/meta.yml Outdated Show resolved Hide resolved
modules/ebi-metagenomics/hifiadapterfilt/meta.yml Outdated Show resolved Hide resolved
modules/ebi-metagenomics/hifiadapterfilt/meta.yml Show resolved Hide resolved
modules/ebi-metagenomics/hifiadapterfilt/meta.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagkaratzas vagkaratzas vagkaratzas requested changes

@mberacochea mberacochea Awaiting requested review from mberacochea

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ge94 @vagkaratzas