Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ref dbs mounts for docker in ips and unifire. Mem limit to emapper --dbmem flag #42

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

mberacochea
Copy link
Member

I've also added a local profile with max_cpus and memory suitable for a laptop/workstation

@mberacochea mberacochea requested a review from tgurbich July 20, 2024 09:28
@mberacochea mberacochea self-assigned this Jul 20, 2024
Copy link
Contributor

@tgurbich tgurbich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Martin! Could you please merge it into dev first instead of main?

@mberacochea mberacochea changed the base branch from main to dev July 20, 2024 10:01
@mberacochea
Copy link
Member Author

Thanks a lot, Martin! Could you please merge it into dev first instead of main?

Yeah, I selected the wrong branch when I created the PR.

@mberacochea
Copy link
Member Author

BTW, this PR should close #38 and #40

Added a local profile with max_cpus and memory suitable for a laptop/workstation
@mberacochea mberacochea force-pushed the bugfix/ips-unipro-docker-mounts-fix branch from 2aeaf3d to 09faeef Compare July 22, 2024 08:30
Copy link

github-actions bot commented Jul 22, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 09faeef

+| ✅ 163 tests passed       |+
#| ❔  29 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.2
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • system_exit - System.exit in main.nf: System.exit(1) [line 47]
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-mettannotator_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mettannotator_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mettannotator_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/usage.md
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowMettannotator.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-mettannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-mettannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-mettannotator_logo_dark.png
  • files_unchanged - File does not exist: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/mettannotator/mettannotator/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-22 08:31:35

@mberacochea mberacochea merged commit 415a674 into dev Jul 22, 2024
4 checks passed
@mberacochea mberacochea deleted the bugfix/ips-unipro-docker-mounts-fix branch July 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants