Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Wrong applied price for ValueStorage-based iPrice(). Also a fix for ArraySize() and const-ness #737

Closed
wants to merge 3 commits into from
Closed

Fixed Wrong applied price for ValueStorage-based iPrice(). Also a fix for ArraySize() and const-ness #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a53dbe7
Fixes C++ error: no matching function for call
kenorb May 28, 2023
a47522b
Merge branch 'v3.000-dev' of https://github.com/EA31337/EA31337-class…
nseam Mar 29, 2024
70f8835
Fixes EA31337/Strategy-Meta_MA_Cross#2. Fixed Wrong applied price for…
nseam Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Array.mqh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ static int GetLowestArrDoubleValue(double& arr[][], int key) {
* - https://www.mql5.com/en/docs/array/arraysize
*/
template <typename X>
static int ArraySize(ARRAY_REF(X, array)) {
static int ArraySize(const ARRAY_REF(X, array)) {
return ::ArraySize(array);
}

Expand Down
8 changes: 7 additions & 1 deletion Storage/ValueStorage.price.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,14 @@ class PriceValueStorage : public HistoryValueStorage<double> {
return _low.Fetch(_shift);
case PRICE_CLOSE:
return _close.Fetch(_shift);
case PRICE_MEDIAN:
return (_high.Fetch(_shift) + _low.Fetch(_shift)) / 2;
case PRICE_TYPICAL:
return (_high.Fetch(_shift) + _low.Fetch(_shift) + _close.Fetch(_shift)) / 3;
case PRICE_WEIGHTED:
return (_high.Fetch(_shift) + _low.Fetch(_shift) + (2 * _close.Fetch(_shift))) / 4;
}
Alert("Wrong applied price for ValueStorage-based iPrice()!");
Alert("Wrong applied price for ValueStorage-based iPrice()! Got ", EnumToString(_ap));
DebugBreak();
return 0;
}
Expand Down
Loading