Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order's closing conditions not loaded on init #705

Closed
kenorb opened this issue Aug 12, 2023 · 0 comments · Fixed by EA31337/EA31337#385 or #708
Closed

Order's closing conditions not loaded on init #705

kenorb opened this issue Aug 12, 2023 · 0 comments · Fixed by EA31337/EA31337#385 or #708
Labels
bug
Milestone
v2.013.1

Comments

@kenorb
Copy link
Member

kenorb commented Aug 12, 2023 •
edited
Loading

When EA tries to load the existing active orders via magic number, the closing conditions aren't loaded.
@kenorb kenorb added the bug label Aug 12, 2023
@kenorb kenorb modified the milestones: v2.013, v2.013.1 Aug 12, 2023
@kenorb kenorb mentioned this issue Aug 5, 2023
Closed
kenorb added a commit that referenced this issue Aug 12, 2023
@kenorb
Workaround for closing order conditions after orders are loaded from …
4432467 
…active pool (GH-705)
kenorb added a commit that referenced this issue Aug 12, 2023
@kenorb
Workaround for closing order conditions after orders are loaded from …
b55af2e 
…active pool (GH-705)
This was referenced Aug 12, 2023
Merged
Merged
@kenorb kenorb mentioned this issue Aug 13, 2023
Closed
kenorb added a commit that referenced this issue Apr 25, 2024
@kenorb
Workaround for closing order conditions after orders are loaded from …
71089fc 
…active pool (GH-705)
kenorb added a commit that referenced this issue Apr 25, 2024
@kenorb
Merge branch 'v3.001-dev-new' into v3.002-dev-new
7ca1f82 
* v3.001-dev-new:
  Workaround for closing order conditions after orders are loaded from active pool (GH-705)
  Trade: TradeParams: Adds max_spread
  Order: Fixes the current volume value when data in orequest is missing
  Order: Refresh order after modification
  Trade: Disables filling modes for MQL4
  EA: Fixes recent issue with error during trade request
  Account/AccountMt: Fixes zero division
kenorb added a commit that referenced this issue Apr 25, 2024
@kenorb
Merge branch 'v3.002-dev-new' into v3.003-dev-new
ea576b6 
* v3.002-dev-new:
  Account/AccountMt: Fixes zero division
  GHA: Compile: Support for workflow calls
  GHA: Compile: Skips clean-up by default
  GHA: Fixes compilation workflows
  Trade: Disables filling modes for MQL4
  Workaround for closing order conditions after orders are loaded from active pool (GH-705)
  Trade: TradeParams: Adds max_spread
  Order: Fixes the current volume value when data in orequest is missing
  Order: Refresh order after modification
  Trade: Disables filling modes for MQL4
  EA: Fixes recent issue with error during trade request
  Account/AccountMt: Fixes zero division
kenorb added a commit that referenced this issue Apr 27, 2024
@kenorb
Workaround for closing order conditions after orders are loaded from …
e4d95af 
…active pool (GH-705)
kenorb added a commit that referenced this issue Apr 27, 2024
@kenorb
Workaround for closing order conditions after orders are loaded from …
ae5d3df 
…active pool (GH-705)
kenorb added a commit that referenced this issue Apr 27, 2024
@kenorb
Merge remote-tracking branch 'origin/v3.001-dev-new' into v3.002-dev-new
efa612e 
* origin/v3.001-dev-new:
  Workaround for closing order conditions after orders are loaded from active pool (GH-705)
  Trade: TradeParams: Adds max_spread
  Order: Fixes the current volume value when data in orequest is missing
  Order: Refresh order after modification
  Trade: Disables filling modes for MQL4
  Account/AccountMt: Fixes zero division
  Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5.
  GHA: Compile: Adds support for path input
kenorb added a commit that referenced this issue Apr 27, 2024
@kenorb
Merge remote-tracking branch 'origin/v3.002-dev-new' into v3.003-dev-new
5cb35fd 
* origin/v3.002-dev-new:
  Workaround for closing order conditions after orders are loaded from active pool (GH-705)
  Trade: TradeParams: Adds max_spread
  Order: Fixes the current volume value when data in orequest is missing
  Order: Refresh order after modification
  Trade: Disables filling modes for MQL4
  Account/AccountMt: Fixes zero division
  Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5.
  GHA: Compile: Adds support for path input
kenorb added a commit that referenced this issue Apr 27, 2024
@kenorb
Merge tag 'v2.013.1' into v3.006-dev-new
cfe9343 
* tag 'v2.013.1':
  Final fix for orders are opened instead of being closed for both MT4 and MT5 (fixes GH-707)
  Fix for orders are opened instead of being closed (GH-707)
  Order: Improves error handling
  Order:Trade: Improves error handling
  Workaround for closing order conditions after orders are loaded from active pool (GH-705)
  Adds close retry counter (GH-703)
kenorb added a commit that referenced this issue May 1, 2024
@kenorb
Merge branch 'v3.007-dev-new' into HEAD
979924a 
* v3.007-dev-new: (246 commits)
  Taskable: Fixes compilation for Taskable.test.mq4
  Std: Uses Alert() and DebugBreak() for MQL only
  Workaround for closing order conditions after orders are loaded from active pool (GH-705)
  Trade: TradeParams: Adds max_spread
  Order: Fixes the current volume value when data in orequest is missing
  Order: Refresh order after modification
  Trade: Disables filling modes for MQL4
  Account/AccountMt: Fixes zero division
  Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5.
  GHA: Compile: Adds support for path input
  ACQUIRE_BUFFERn / RELEASE_BUFFERn functionality required for EA31337/EA31337-indicators-stats#1
  SerializerConverter: Fixes error: member reference base type 'C *' is not a structure
  Fixes nullptr undeclared identifier
  Minor fixes
  C++ compatibility fixes.
  Account/AccountMt: Fixes zero division
  GHA: Compile: Support for workflow calls
  GHA: Compile: Skips clean-up by default
  GHA: Fixes compilation workflows
  Trade: Disables filling modes for MQL4
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.013.1
Development

Successfully merging a pull request may close this issue.

Order fixes for v2.013.1 EA31337/EA31337
Order fixes for v2.013.1 EA31337/EA31337-classes
1 participant
@kenorb