Fixes timeframe handling

EA31337 · Jun 27, 2022 · fc68e55 · fc68e55
1 parent b010f5d
commit fc68e55
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/Indicator.mqh b/Indicator.mqh
@@ -402,6 +402,11 @@ class Indicator : public IndicatorData {
    */
   // ENUM_TIMEFRAMES GetTf() { return Get<ENUM_TIMEFRAMES>(CHART_PARAM_TF); }
 
+  /**
+   * Gets indicator's time-frame.
+   */
+  ENUM_TIMEFRAMES GetTf() { return iparams.tf.GetTf(); }
+
   /**
    * Gets indicator's signals.
    *

diff --git a/IndicatorBase.h b/IndicatorBase.h
@@ -320,18 +320,11 @@ class IndicatorBase : public Chart {
    */
   // virtual bool ToString() = NULL; // @fixme?
 
-  /* Methods to get rid of */
-
   /**
    * Gets indicator's symbol.
    */
   string GetSymbol() { return Get<string>(CHART_PARAM_SYMBOL); }
 
-  /**
-   * Gets indicator's time-frame.
-   */
-  ENUM_TIMEFRAMES GetTf() { return Get<ENUM_TIMEFRAMES>(CHART_PARAM_TF); }
-
   /* Defines MQL backward compatible methods */
 
   double iCustom(int& _handle, string _symbol, ENUM_TIMEFRAMES _tf, string _name, int _mode, int _shift) {

diff --git a/IndicatorData.mqh b/IndicatorData.mqh
@@ -474,8 +474,8 @@ class IndicatorData : public IndicatorBase {
 
   /* Getters */
 
-  int GetBarsCalculated() {
-    int _bars = Bars(GetSymbol(), GetTf());
+  int GetBarsCalculated(ENUM_TIMEFRAMES _tf = NULL) {
+    int _bars = Bars(GetSymbol(), _tf);
 
     if (!idparams.Get<bool>(STRUCT_ENUM(IndicatorDataParams, IDATA_PARAM_IS_FED))) {
       // Calculating start_bar.
@@ -521,7 +521,7 @@ class IndicatorData : public IndicatorBase {
       Ref<IndicatorData> _indi = FetchDataSource(_type);
       if (!_indi.IsSet()) {
         Alert(GetFullName(), " does not define required indicator type ", EnumToString(_type), " for symbol ",
-              GetSymbol(), ", and timeframe ", GetTf(), "!");
+              GetSymbol(), "!");
         DebugBreak();
       } else {
         indicators.Set((int)_type, _indi);

diff --git a/Storage/ValueStorage.indicator.h b/Storage/ValueStorage.indicator.h
@@ -51,8 +51,8 @@ class IndicatorBufferValueStorage : public HistoryValueStorage<C> {
   /**
    * Constructor.
    */
-  IndicatorBufferValueStorage(IndicatorData *_indi, int _mode = 0, bool _is_series = false)
-      : indicator(_indi), mode(_mode), HistoryValueStorage(_indi.GetSymbol(), _indi.GetTf()) {}
+  IndicatorBufferValueStorage(IndicatorData *_indi, int _mode = 0, ENUM_TIMEFRAMES _tf = NULL, bool _is_series = false)
+      : indicator(_indi), mode(_mode), HistoryValueStorage(_indi.GetSymbol(), _tf) {}
 
   /**
    * Fetches value from a given shift. Takes into consideration as-series flag.