add aerosol aeronet as a default e3sm_diags set #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengzhuzhang
commented
Aug 2, 2022
| @@ -164,7 +164,7 @@ reference_data_path_ts_rof = string(default="") | |||
| # Required for "model_vs_model" "enso_diags"/"streamflow"/"tc_analysis" runs: `ref_final_yr`, `ref_start_yr` | |||
| run_type = string(default="model_vs_obs") | |||
| # The sets to run | |||
| # All available sets = "lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","enso_diags","qbo","diurnal_cycle","annual_cycle_zonal_mean","streamflow","zonal_mean_2d_stratosphere","tc_analysis","area_mean_time_series" | |||
| # All available sets = "lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","enso_diags","qbo","diurnal_cycle","annual_cycle_zonal_mean","streamflow","zonal_mean_2d_stratosphere","tc_analysis","area_mean_time_series","aerosol_aeronet", | |||
There was a problem hiding this comment.
Hey Ryan, I recall that a comma is needed for configuration parameters, so I just have it in here although this line is commented out.
There was a problem hiding this comment.
Yes, the comma should included here since this is an example of what a user would type.
| @@ -173,7 +173,7 @@ run_type = string(default="model_vs_obs") | |||
| # "diurnal_cycle" requires `climo_diurnal_subsection`, `climo_diurnal_frequency`, and `dc_obs_climo` to be set. | |||
| # "streamflow" requires `streamflow_obs_ts` to be set. | |||
| # "tc_analysis" requires `tc_obs` to be set. | |||
| sets = string_list(default=list("lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","annual_cycle_zonal_mean","zonal_mean_2d_stratosphere")) | |||
| sets = string_list(default=list("lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","annual_cycle_zonal_mean","zonal_mean_2d_stratosphere","aerosol_aeronet")) | |||
There was a problem hiding this comment.
It seems a comma is not needed here.
There was a problem hiding this comment.
Correct, the comma is only needed from the user in the configuration file. In the default.ini file, no comma is needed.
forsyth2
approved these changes
Aug 2, 2022
| @@ -164,7 +164,7 @@ reference_data_path_ts_rof = string(default="") | |||
| # Required for "model_vs_model" "enso_diags"/"streamflow"/"tc_analysis" runs: `ref_final_yr`, `ref_start_yr` | |||
| run_type = string(default="model_vs_obs") | |||
| # The sets to run | |||
| # All available sets = "lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","enso_diags","qbo","diurnal_cycle","annual_cycle_zonal_mean","streamflow","zonal_mean_2d_stratosphere","tc_analysis","area_mean_time_series" | |||
| # All available sets = "lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","enso_diags","qbo","diurnal_cycle","annual_cycle_zonal_mean","streamflow","zonal_mean_2d_stratosphere","tc_analysis","area_mean_time_series","aerosol_aeronet", | |||
There was a problem hiding this comment.
Yes, the comma should included here since this is an example of what a user would type.
| @@ -173,7 +173,7 @@ run_type = string(default="model_vs_obs") | |||
| # "diurnal_cycle" requires `climo_diurnal_subsection`, `climo_diurnal_frequency`, and `dc_obs_climo` to be set. | |||
| # "streamflow" requires `streamflow_obs_ts` to be set. | |||
| # "tc_analysis" requires `tc_obs` to be set. | |||
| sets = string_list(default=list("lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","annual_cycle_zonal_mean","zonal_mean_2d_stratosphere")) | |||
| sets = string_list(default=list("lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","annual_cycle_zonal_mean","zonal_mean_2d_stratosphere","aerosol_aeronet")) | |||
There was a problem hiding this comment.
Correct, the comma is only needed from the user in the configuration file. In the default.ini file, no comma is needed.
|
This is slipped... The PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aerosol aeronet set from e3sm_diags as default set.
close #287