Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILAMB for Compy #247

Merged
merged 1 commit into from
Jun 3, 2022
Merged

ILAMB for Compy #247

merged 1 commit into from
Jun 3, 2022

Conversation

forsyth2
Copy link
Collaborator

Support ILAMB on Compy. The Compy component of #229.

@forsyth2 forsyth2 added the semver: new feature New feature (will increment minor version) label May 31, 2022
@forsyth2 forsyth2 self-assigned this May 31, 2022
@forsyth2
Copy link
Collaborator Author

Testing with:

[default]
case = 20210528.v2rc3e.piControl.ne30pg2_EC30to60E2r2.chrysalis
environment_commands = "source /share/apps/E3SM/conda_envs/load_latest_e3sm_unified_compy.sh"
#input = /compyfs/fors729/e3sm_unified_test_zppy/20210528.v2rc3e.piControl.ne30pg2_EC30to60E2r2.chrysalis                     
input = /compyfs/fors729/zstash_extraction_20220526/v2.LR.historical_0201
input_subdir = archive/atm/hist
mapping_file = /compyfs/zender/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
output = /compyfs/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201
partition = short
walltime = "02:00:00"
www = /compyfs/www/fors729/zppy_ilamb_compy_output

[ts]
active = True
frequency = "monthly"
years = "1851:1855:2",

  [[ atm_monthly_180x360_aave ]]
  input_files = "eam.h0"

  [[ land_monthly ]]
  input_files = "elm.h0"
  input_subdir = "archive/lnd/hist"
  vars = "FSH,LAISHA,LAISUN,RH2M"

[ilamb_run]
active = True
grid = '180x360_aave'
short_name = 'v2.LR.historical_0201'
ts_num_years = 2
years = "1851:1853:2",

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jun 1, 2022

Testing with the following:

[default]
case = v2.LR.historical_0201
environment_commands = "source /share/apps/E3SM/conda_envs/load_latest_e3sm_unified_compy.sh"
#input = /compyfs/fors729/e3sm_unified_test_zppy/20210528.v2rc3e.piControl.ne30pg2_EC30to60E2r2.chrysalis                                                                                                        
input = /compyfs/fors729/zstash_extraction_20220526/v2.LR.historical_0201
input_subdir = archive/atm/hist
mapping_file = /compyfs/zender/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
output = /compyfs/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201
partition = short
walltime = "02:00:00"
www = /compyfs/www/fors729/zppy_ilamb_compy_output

[ts]
active = True
frequency = "monthly"
years = "1851:1855:2",
ts_fmt = "cmip"

  [[ atm_monthly_180x360_aave ]]
  input_files = "eam.h0"

  [[ land_monthly ]]
  input_files = "elm.h0"
  input_subdir = "archive/lnd/hist"
  vars = "FSH,LAISHA,LAISUN,RH2M"

[ilamb_run]
active = True
grid = '180x360_aave'
short_name = 'v2.LR.historical_0201'
ts_num_years = 2
years = "1851:1853:2",

Results: https://compy-dtn.pnl.gov/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201/ilamb/180x360_aave_1851-1852/

@forsyth2 forsyth2 marked this pull request as ready for review June 1, 2022 22:11
Copy link
Collaborator Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengzhuzhang This is ready for review. I was able to generate https://compy-dtn.pnl.gov/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201/ilamb/180x360_aave_1851-1852/ using the cfg file in the previous comment.

I'll also test on Cori.

@@ -58,6 +57,7 @@ echo ===== RUN ILAMB =====
echo

# Run diagnostics
# Not required TODO?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can generate https://compy-dtn.pnl.gov/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201/ilamb/180x360_aave_1851-1852/ without this TODO item. Is it necessary? (Or is it just that Compy and LCRC use the same mpi run format?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using ilamb_run means to run in serial, with more variables it could be more helpful using mpi. It might be good to check with @minxu74 . Hey Min, we are working on support ilamb in zppy on multiple platforms, and do you think it is necessary to running with MPI? Thanks!

@chengzhuzhang
Copy link
Collaborator

I think the PR itself is okay to merge.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jun 3, 2022

I'm getting the following running with these changes on Cori. So that looks like an MPI issue. I think I can still merge this PR and get a release candidate started though, debugging this issue as part of the larger release testing.

Fri Jun  3 09:07:46 2022: [unset]:_pmi_alps_init:alps_get_placement_info returned with error -1
Fri Jun  3 09:07:46 2022: [unset]:_pmi_init:_pmi_alps_init returned -1
[Fri Jun  3 09:07:46 2022] [c6-5c0s14n1] Fatal error in PMPI_Init_thread: Other MPI error, error stack:
MPIR_Init_thread(537):
MPID_Init(246).......: channel initialization failed
MPID_Init(647).......:  PMI2 init failed: 1
/var/spool/slurmd/job59814450/slurm_script: line 234: 61937 Aborted                 e3sm_to_cmip --output-path ${dest_cmip}/${tmp_dir} --\
var-list 'pr, tas, rsds, rlds, rsus' --realm atm --input-path ${input_dir} --user-metadata /global/cscratch1/sd/forsyth/zppy_ilamb_cori_o\
utput/v2.LR.historical_0201/post/scripts/${workdir}/default_metadata.json --num-proc 12 --tables-path ${cmortables_dir}

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jun 3, 2022

Not going to commit the example cfg, but copying here for reference:

[default]
case = v2.LR.historical_0201
environment_commands = "source /share/apps/E3SM/conda_envs/load_latest_e3sm_unified_compy.sh"
input = /compyfs/fors729/zstash_extraction_20220526/v2.LR.historical_0201
input_subdir = archive/atm/hist
mapping_file = /compyfs/zender/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc
output = /compyfs/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201
partition = short
walltime = "02:00:00"
www = /compyfs/www/fors729/zppy_ilamb_compy_output

[ts]
active = True
frequency = "monthly"
years = "1851:1855:2",
ts_fmt = "cmip"

  [[ atm_monthly_180x360_aave ]]
  input_files = "eam.h0"

  [[ land_monthly ]]
  input_files = "elm.h0"
  input_subdir = "archive/lnd/hist"
  vars = "FSH,LAISHA,LAISUN,RH2M"

[ilamb_run]
active = True
grid = '180x360_aave'
short_name = 'v2.LR.historical_0201'
ts_num_years = 2
years = "1851:1853:2",

@forsyth2 forsyth2 merged commit 4bae9b4 into main Jun 3, 2022
@forsyth2 forsyth2 deleted the ilamb-compy branch June 3, 2022 17:16
This was referenced Jun 8, 2022
@forsyth2 forsyth2 mentioned this pull request Dec 16, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: new feature New feature (will increment minor version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants