-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILAMB for Compy #247
ILAMB for Compy #247
Conversation
Testing with:
|
Testing with the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengzhuzhang This is ready for review. I was able to generate https://compy-dtn.pnl.gov/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201/ilamb/180x360_aave_1851-1852/ using the cfg file in the previous comment.
I'll also test on Cori.
@@ -58,6 +57,7 @@ echo ===== RUN ILAMB ===== | |||
echo | |||
|
|||
# Run diagnostics | |||
# Not required TODO? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can generate https://compy-dtn.pnl.gov/fors729/zppy_ilamb_compy_output/v2.LR.historical_0201/ilamb/180x360_aave_1851-1852/ without this TODO item. Is it necessary? (Or is it just that Compy and LCRC use the same mpi run format?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using ilamb_run
means to run in serial, with more variables it could be more helpful using mpi. It might be good to check with @minxu74 . Hey Min, we are working on support ilamb in zppy on multiple platforms, and do you think it is necessary to running with MPI? Thanks!
I think the PR itself is okay to merge. |
I'm getting the following running with these changes on Cori. So that looks like an MPI issue. I think I can still merge this PR and get a release candidate started though, debugging this issue as part of the larger release testing.
|
Not going to commit the example
|
Support ILAMB on Compy. The Compy component of #229.