Support decompositions with extra outermost dimensions #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqwu
force-pushed
the
dqwu/decomp_extra_dims
branch
2 times, most recently
from
e87f5da to
ec8cd6d
Compare
In PIO1, a decomposition can have extra outermost dimensions with their lengths all set to 1. For example, we can define a 3D decomposition of [1 x 10 x 20] to read/write a 2D variable of [10 x 20], or a 3D record variable of [time x 10 x 20]. We need to test non-record variable, record variable (uses unlimited time dimension) and quasi-record variable (uses limited time dimension) for extra dimensions. For these tests to pass, existing PIO2 code needs to be updated to get matched start/count values from the decomposition.
dqwu
force-pushed
the
dqwu/decomp_extra_dims
branch
from
ec8cd6d to
87b447d
Compare
Update existing PIO2 code to get matched start/count values from a decomposition that might have extra dimensions. For start/count arrays, correct some for loops on the condition part according to their lengths. Strictly speaking, record variables are ones that use unlimited time dimension (rec_var flag is set). However, some E3SM tests do handle "quasi-record" variables (use limited time dimension, thus rec_var flag is NOT set). If a variable has more than one dimension and its record number has been set, we assume that it is either a record variable or a "quasi-record" one (handled similarly).
dqwu
force-pushed
the
dqwu/decomp_extra_dims
branch
from
87b447d to
d0163d2
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PIO1, a decomposition can have extra outermost dimensions
with their lengths all set to 1. For example, we can define a
3D decomposition of [1 x 10 x 20] to read/write a 2D variable
of [10 x 20], or a 3D record variable of [time x 10 x 20].
This feature is not supported by PIO2 so far. PIO2 might get
mismatched start/count values from the decomposition, and
access an array out of its bounds.
New Fortran unit tests are added for this enhancement, and
PIO2 code is updated to get correct start/count values from
the decomposition.
This feature branch has been extensively tested. All PIO2 unit
tests, e3sm_developer tests and cime_developer tests passed.
A High-resolution F case run on Cori also passed.
Fixes #106