Add a restart test to cosine bell #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
enhancement
xylar
added
the
Omega PR required
|
The restart test case nearly works but needs a fix for E3SM-Project/Omega#181. |
This was referenced Dec 5, 2024
|
It works!!! Using a test merge of E3SM-Project/Omega#184 with the current Omega |
xylar
added
Omega PR finished
cbegeman
reviewed
Dec 20, 2024
| component=component, name=name, subdir=subdir, | ||
| mesh=base_mesh_step, init=init_step, | ||
| refinement_factor=refinement_factor, | ||
| refinement=refinement) |
There was a problem hiding this comment.
Suggested change
| refinement=refinement) | |
| refinement=refinement, | |
| do_restart=name == 'restart_run') |
Since you end up using the logical do_restart in dynamic_model_config, should we just use this as an argument rather than checking step names?
cbegeman
approved these changes
Dec 20, 2024
This is needed if we are translating dimension and variable names between native model names and common Polaris names.
xylar
force-pushed
the
cosine-bell-restart
branch
from
0cb3690 to
ee6d56d
Compare
Add a `do_restart` attribute to keep track of which runs are restart runs, rather than using the step name.
TestingI successfully ran both the |
|
I need to take care of documentation and adding tests to suites before I merge. |
Update cosine_bell suite to include all tests. Remove cosine_bell_cached_init suite, which has not been well maintained.
|
Okay, docs and test suites are up-to-date. |
xylar
force-pushed
the
cosine-bell-restart
branch
from
2ac8c51 to
2b6571d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds a restart test to the cosine bell configuration. This requires some changes to the validation framework for comparing variables to support the translation that Polaris performs between Omega native dimension and variable names and those for MPAS-Ocean that the Polaris ocean component uses generally.
A small amount of related cleanup is also included.
Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes