Support the Omega time coordinate
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
ocean
|
Needs #231 and E3SM-Project/Omega#169 |
|
I was able to run the manufactured solution test case successfully, including analysis. However, without E3SM-Project/Omega#170, it doesn't behave correctly (as expected) and the convergence rate is terrible. |
|
Viz should be tested after #250 is merged and this gets rebased. |
xylar
force-pushed
the
support-omega-time-coord
branch
from
51be5cb to
bdd5ae4
Compare
Merged
6 tasks
xylar
force-pushed
the
support-omega-time-coord
branch
3 times, most recently
from
b64edf8 to
c43e7df
Compare
3 tasks
TestingTested with manufactured solution on Chrysalis, see #231 (comment) |
xylar
added
Omega PR finished
cbegeman
reviewed
Dec 20, 2024
cbegeman
reviewed
Dec 20, 2024
cbegeman
approved these changes
Dec 20, 2024
This merge adds a function `time_since_start()` that converts `xtime` to seconds since the beginning of the simulation.
xylar
force-pushed
the
support-omega-time-coord
branch
from
93e8fc4 to
7f79974
Compare
|
Retested with suggested changes using Omega on Chrysalis to run the manufactured_solution test case. |
|
Thank you, @cbegeman, for the review including the excellent suggested changes, which I have made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes the manufactured solution analysis task in Omega by using the
timecoordinate instead of the MPAS-Oceanxtimevariable.It also attempts to use
timein the viz step but testing is currently inhibited by #248Checklist
Testingcomment in the PR documents testing used to verify the changes