-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Omega support to Cosine Bell tests #242
Conversation
Omega is using newer modules on Chrysalis than Polaris, so we need to update the Polaris version and build new spack packages before this can go in. |
7ec947e
to
02598f6
Compare
02598f6
to
c499bbc
Compare
With E3SM-Project/Omega#169, this is working through |
c499bbc
to
52fc195
Compare
52fc195
to
dddbf1d
Compare
Seems to be working! Convergence isn't what it should be, so we need to look into that. Viz is messed up but can be fixed (in collaboration with @andrewdnolan using https://github.com/E3SM-Project/mosaic/). |
dddbf1d
to
53620bc
Compare
We should presumably do an MPAS-Ocean run with centered tracer adveciton for comparison. |
53620bc
to
2cd075e
Compare
I'll do this. I originally thought we needed MPAS-O code changes but we might just need a few namelist changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! I ran it for MPAS-O; I think your Omega testing is likely sufficient. Thanks, @xylar
I will plan to add a separate test for 2nd order advection in a follow-on PR for benchmarking Omega against MPAS-O. |
2cd075e
to
26688d6
Compare
Okay, this runs fine (still fails |
Thanks again @cbegeman!! |
Checklist
Testing
comment in the PR documents testing used to verify the changes