Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Omega support to Cosine Bell tests #242

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 8, 2024

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added enhancement New feature or request ocean Related to ocean tests or analysis Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Nov 8, 2024
@xylar xylar self-assigned this Nov 8, 2024
@xylar
Copy link
Collaborator Author

xylar commented Nov 8, 2024

Omega is using newer modules on Chrysalis than Polaris, so we need to update the Polaris version and build new spack packages before this can go in.

@xylar
Copy link
Collaborator Author

xylar commented Dec 2, 2024

With E3SM-Project/Omega#169, this is working through forward steps but viz steps are failing because the dimensions are cannot yet be translated, see #172

@xylar
Copy link
Collaborator Author

xylar commented Dec 4, 2024

Seems to be working!

Convergence isn't what it should be, so we need to look into that.
convergence_tracer1

Viz is messed up but can be fixed (in collaboration with @andrewdnolan using https://github.com/E3SM-Project/mosaic/).
init
final

init
final

init
final

init
final

@xylar
Copy link
Collaborator Author

xylar commented Dec 4, 2024

For comparison, MPAS-Ocean is performing considerably better, presumably because of higher order tracer advection schemes:
convergence_tracer1

@xylar xylar force-pushed the cosine-bell-for-omega branch from dddbf1d to 53620bc Compare December 4, 2024 18:24
@xylar
Copy link
Collaborator Author

xylar commented Dec 4, 2024

We should presumably do an MPAS-Ocean run with centered tracer adveciton for comparison.

@xylar xylar force-pushed the cosine-bell-for-omega branch from 53620bc to 2cd075e Compare December 5, 2024 11:11
@xylar xylar added Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished and removed Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Dec 16, 2024
@cbegeman
Copy link
Collaborator

cbegeman commented Dec 20, 2024

We should presumably do an MPAS-Ocean run with centered tracer adveciton for comparison.

I'll do this. I originally thought we needed MPAS-O code changes but we might just need a few namelist changes.

@cbegeman
Copy link
Collaborator

I get the same convergence for MPAS-Ocean (tracer adv order 2, monotonic off):
image

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! I ran it for MPAS-O; I think your Omega testing is likely sufficient. Thanks, @xylar

@cbegeman
Copy link
Collaborator

I will plan to add a separate test for 2nd order advection in a follow-on PR for benchmarking Omega against MPAS-O.

@xylar xylar force-pushed the cosine-bell-for-omega branch from 2cd075e to 26688d6 Compare December 23, 2024 11:48
@xylar xylar marked this pull request as ready for review December 23, 2024 11:48
@xylar
Copy link
Collaborator Author

xylar commented Dec 23, 2024

Okay, this runs fine (still fails analysis step) after a rebase.

@xylar
Copy link
Collaborator Author

xylar commented Dec 23, 2024

Thanks again @cbegeman!!

@xylar xylar merged commit d6bc3a1 into E3SM-Project:main Dec 23, 2024
5 checks passed
@xylar xylar deleted the cosine-bell-for-omega branch December 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean Related to ocean tests or analysis Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants