-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add barotropic gyre task #241
Add barotropic gyre task #241
Conversation
This PR depends on MPAS-Dev/MPAS-Tools#590 for the BSF routine. |
TestingThis case has been run with MPAS-O on chrys, intel-impi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4418742
to
f56f1f6
Compare
@xylar Thanks for reviewing! I made those changes and re-ran just the initial state step. |
CI failures are expected until we get MPAS-Tools sorted out. |
f56f1f6
to
9b4e73b
Compare
9b4e73b
to
a038dfb
Compare
Great, looks good so far. I'll take a final look in the morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I ran it though the paces again and got the same comparison plot from the analysis step as above.
@xylar Thank you for reviewing and prioritizing the MPAS-Tools update! |
The barotropic gyre test case is added in order to evaluate linearized barotropic ocean dynamics alongside laplacian viscosity and surface wind forcing. This is the Munk model (1950). The variant of this test case with a balance between wind stress and bottom stress due to drag (the Stommel model) is not included.
By default, only a short forward step is run. The long forward step needed to bring the model to equilibrium and evaluate the numerical solution against an analytical solution may be run by changing the
steps_to_run
argument in the config file after setting up the test case.Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes