Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #86cae16d1b7c4 from CICE-Consortium/main Aug 19, 2023 #27

Conversation

apcraig
Copy link
Collaborator

@apcraig apcraig commented Aug 19, 2023

Includes changes to advanced snow physics and the repeat-ridging diagnostic.

dabail10 and others added 4 commits July 21, 2023 15:01
* snwgrain bug fix; use snwredist and snwgrain instead of tr_snow in columnphysics; chicoma machine files

* Use snow tracers only for snwredist or snwgrain cases that require them in columnphysics/.  Compute massice and massliq for either mushy or BL99 thermo.

* initialize snow density tracer as rhosnew, as in E3SM

* do not set rhos_cmpn when the tracer might be undefined in the driver

* assume all condensation becomes solid ice, for snow mass tracers
…o cice-consortium/E3SM-icepack-initial-integration

Merge #86cae16d1b7c4 from CICE-Consortium/main Aug 19, 2023
@apcraig apcraig requested a review from eclare108213 August 19, 2023 23:09
@apcraig
Copy link
Collaborator Author

apcraig commented Aug 20, 2023

Full Icepack test suite run on cheyenne. All results pass and bit-for-bit with Icepack main (#86cae16d1b) except modal tests (as expected).

Copy link
Collaborator

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on visual inspection and Consortium testing. Will pull into the E3SM icepack-integration fork for further testing.

@eclare108213 eclare108213 merged commit e751022 into E3SM-Project:cice-consortium/E3SM-icepack-initial-integration Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants