Merge Consortium Icepack main #b0283b287f April 18, 2023 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsortium#435) Fix documentation noted in E3SM-Project#21 Fix documentation in issue CICE-Consortium#430 and CICE-Consortium#422
…-Consortium#436) Some problems were discovered in E3SM testing with Icepack.
…o icep230418 Merge Consortium Icepack main #b0283b287f April 18, 2023
eclare108213
approved these changes
Apr 21, 2023
One question: Why does this not show up as a difference also in icepack restart files, since we include a land grid cell in our icepack testing configuration? |
|
Merging now to get the wlat fix. |
eclare108213
merged commit e3e36a7
into
E3SM-Project:cice-consortium/E3SM-icepack-initial-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Merge Consortium Icepack main #b0283b287f April 18, 2023
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Icepack and CICE are bit-for-bit with current versions on the Consortium, tested on cheyenne full test suite. Only exceptions are icepack modal tests and CICE restart file differences due to changes in Tf values on non-ice grid points, both are expected.
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Fix optional argument wlat problems
Update icepack_write_parameters to improve output format
Update documentation for a few different outstanding issues