-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update aerosol code for vertical bgc #15
update aerosol code for vertical bgc #15
Conversation
Has any testing been done? Do you need me to do any testing to help? |
I ran a single regression test, which passed: In CICE/Icepack, I do not expect there to be any answer changes for standard aerosols, and there will definitely be answer changes for zbgc aerosols (the opposite is true for MPAS-SI). @njeffery and I still need to get the ISPOL- (and maybe NICE-) forced comparison tests set up. At the moment, I do not think the zbgc changes in icepack_aerosol.F90 will run because it's missing a new subroutine argument. More work needs to be done on the zbgc port before we can test this, I think. I also would like to change the names of the subroutines to indicate when they are used. E.g. change update_aerosol to update_aerosol_traero and update_snow_bgc to update_aerosol_zbgc_snow. Other suggestions welcome, including for the zbgc porting process. |
@eclare108213 : in mpas-seaice, hs_ssl_min is defined in ice_colpkg_shared, just like hs_ssl and hi_ssl. |
! Increase aerosol in snow surface due to deposition | ||
! and vertical cycling : after update_aerosol | ||
! Aerosol in snow for vertical biogeochemistry with mushy thermodynamics | ||
! Called from icepack_algae.F90 when z_tracers=T (replaces update_aerosol) | ||
|
||
subroutine update_snow_bgc (dt, nblyr, & | ||
nslyr, & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is in update_snow_bgc, so this should not impact tr_aero unless z_tracers is on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, just tested it out with tr_aero = .true. and NTRAERO=3. It is bfb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by inspection. These changes are consistent with what's currently in mpassi.
This PR is really old (Nov 2022!) so we'll probably need to pull its commits into a new branch for further testing, to avoid conflicts. And we probably don't want to merge it directly into E3SM's icepack fork, so the branch would need to be in icepack main, then PR'd back to E3SM. Maybe @apcraig or @dabail10 can help... |
I can help next week. Shouldn't be difficult to create a PR in Icepack in the Consortium, then move it over to E3SM Icepack after testing and merging. |
replacing this PR with #30 |
Merge aerosol related changes from MPAS-SI into Icepack
@njeffery @eclare108213
ENTER INFORMATION HERE
Replaces vertical BGC aerosol code in Icepack with MPAS-SI version, which requires a new parameter, and updates related shortwave code from the same commit. The original aerosol tracer code is unchanged.
icepack_aerosol.F90
icepack_parameters.F90
icepack_shortwave.F90