Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify bi and tri-grid in land for MOAB coupler. #6754

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

iulian787
Copy link
Contributor

@iulian787 iulian787 commented Nov 18, 2024

Simplify the land grid instantiation for moab driver
Do not differentiate anymore between bi-grid or trigrid.
Also fix errors related to aream initialization for rof model

[BFB]

use only the point cloud
it is enough for import/export
it should be better to compute ourselves, if we have the
mesh information
this could be a performance sink
@rljacob rljacob self-assigned this Nov 18, 2024
@rljacob rljacob requested a review from vijaysm November 18, 2024 17:02
@rljacob rljacob changed the title Iulian787/land grid simple simplify bi and tri-grid in land for MOAB coupler. Nov 18, 2024
@rljacob rljacob added BFB PR leaves answers BFB maint-3.0 labels Nov 18, 2024
@rljacob rljacob merged commit 0e747dc into maint-3.0 Nov 25, 2024
8 checks passed
@rljacob rljacob deleted the iulian787/land_grid_simple branch November 25, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Coupler maint-3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants