-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FATES API 35 compatibilty #6419
Conversation
This PR is a work in progress. At the least, an updated FATES parameter file has to be loaded and pointed to as the default, before tests can complete. |
Running |
All tests ran successfullly except for The former is due to needing to update the history output list for the testmod, which I've fixed with bd00c67. I'm retesting that now. The later is a little weirder as it hit the wall clock limit, even though the |
Setting fates_hist_dimlevel with a single line (i.e. = 2,2) fails during ELMBuildNamelist. Adjust the assignment to accomodate this. This also removes hist_ndens to avoid issue E3SM-Project#1106
Resubmitting The @bishtgautam this is ready to review. |
Thanks for applying that fix @glemieux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I have one minor comment for you to consider.
FYI @bishtgautam there's a recent fix (NGEET/fates#1208) to a fates-side issue related to this API update that I'd like to point this PR at once it's done testing. ETA for it is sometime later today. |
@bishtgautam The testing on the fates side for the new PR is running into snags, so I'm going stick with the current fates tag that this PR is pointing to now. Regression testing on |
@bishtgautam I've updated this PR with the latest fates tag having completed testing and integrated NGEET/fates#1208. I've retested this PR and the results are still the same as prior. This is good to integrate. |
The FATE API has been updated which includes 1) control over the dimensionality of FATES history output and 2) an update to the parameter file format. This set of changes makes E3SM compatible with FATES tag sci.1.76.3_api.35.1.0. [BFB] except for FATES
The FATE API has been updated which includes
E3SM compatible with FATES tag sci.1.76.3_api.35.1.0.
[BFB] except for FATES