Change Ocean conservationCheck output frequency #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingThis PR was found to increase total compute time by 0.5% on perlmutter cpu for a 1-month B case. |
should be "1 day", right? |
|
@xylar Yes, of course. Thanks for catching that! |
|
@jonbob The test that I ran ( |
jonbob
added a commit
that referenced
this pull request
Jun 4, 2024
#6412) Change Ocean conservationCheck output frequency For reasons that are not entirely clear, we have found that the ocean's conservation analysis member outputs with the wrong start time when the output frequency is 1 month. This issue is fixed when the frequency is increased (1 day and 10 days were tested). Here, we change the default output frequency of the conservationCheckOutput stream to 1 day. [BFB]
|
passes:
merged to next |
|
Thanks for the testing @jonbob! |
jonbob
approved these changes
Jun 5, 2024
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Jun 30, 2024
This merge updates the E3SM-Project submodule from [8939709](https://github.com/E3SM-Project/E3SM/tree/8939709) to [752f281b15](https://github.com/E3SM-Project/E3SM/tree/752f281b15). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6412 - [ ] (ocn) E3SM-Project/E3SM#6434 - [ ] (ocn) E3SM-Project/E3SM#6420
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that are not entirely clear, we have found that the ocean's conservation analysis member outputs with the wrong start time when the output frequency is 1 month. This issue is fixed when the frequency is increased (1 day and 10 days were tested). Here, we change the default output frequency of the
conservationCheckOutputstream to 1 day.Fixes MPAS-Dev/MPAS-Analysis#999